-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rules): automatic refire with backoff #732
Conversation
/build_test |
Workflow started at 12/3/2024, 3:22:10 PM. View Actions Run. |
No OpenAPI schema changes detected. |
No GraphQL schema changes detected. |
CI build and push: At least one test failed ❌ |
/build_test |
Workflow started at 12/5/2024, 9:49:48 AM. View Actions Run. |
No GraphQL schema changes detected. |
No OpenAPI schema changes detected. |
CI build and push: All tests pass ✅ |
fa533f4
to
c291681
Compare
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #731
Description of the change:
Adds logic for automatic retry when an automated rule is activated but fails. This can happen because the discovered target application is not yet actually ready to accept requests, or because of some network hiccup, etc. Previously if an automated rule activation failed then Cryostat would never retry and the rule would not take effect on the target, until some other event caused a reactivation (rule disable/reenable, stored credentials added, target modified, target lost/found).
Motivation for the change:
Increases reliability of automated rules.
How to manually test:
make sample_app
oc rollout restart deployment quarkus-test
,oc scale deployment quarkus-test --replicas=n
commands to cause targets to appear and disappear. Verify that automated rules consistently activate against these targets. There may be a slight delay in activation at times due to the retry/backoff behaviour.